-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full revocation status list is actually required for revocable credential issuance? #227
Comments
The full revocation status list is there to support Verifiable Data Registry (VDR) methods that require the full state of the RevReg be tracked, vs. Indy’s deltas. I don’t think it has anything to do with the issuance type AFAIK. In the full state usage, the flag could save the first full state entry. On your second statement, I don’t think it is quite right. The spec. is a ledger-agnostic version of the existing functionality, and since |
Thanks @swcurran for the answer! I started my reasoning considering There are, however, a few references to this concept:
Should it be included and marked as "deprecated" or "kept for legacy reasons but please please please don't use it"? |
This is not necessarily true. The data model in this spec always contains the full state (so for every index whether it is revoked / unrevoked ). Therefore the issuance_by_default or issuance_on_demand doesn't matter anymore. You could have started with either of them, but the accumulator that you will derive from the full state will be the same as we have all the indexes with their state (instead of how it used to be where you got "this is the starting point (all revoked or all unrevoked) and this is how it changed over time)"
I think this makes sense. From what I remember there is a separate method to update the status list. So if you want to use issuance_on_demand, you can call the issue method first, and then separately call the update_status_list method right? This way issuance is separate from managing which credentials are revoked
So as mentioned above. To the spec, it doesn't matter. You always have the full state in the data model, in which case the issuance type doesn't change the end result |
Currently, the library requires us to pass a full revocation status list object when issuing revocable credentials. From my understanding, this is mostly needed to determine whether the revocation status type is
issuance_by_default
orissuance_on_demand
(as seen here), and, in the latter case to determine the new accumulator value (as seen here).However, as
issuance_type
has been removed from the spec and now only issuance by default is allowed, I think it would make sense remove this possibility from this library, which will result in a simplified code that will not require the consumer application to provide the revocation status list object every time a credential is issued.Am I missing something?
The text was updated successfully, but these errors were encountered: