You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I raised a question on Discord and it was recommended I raise it as an issue to track here. Original messasge pasted below:
I was reading through this issue #194 and had a question:
With the link secret (formerly master secret) now being returned as just a plain old string value, should we be thinking about zeroing out memory where the secret was held? I'm not in the habit of thinking about this in python but that was perhaps one advantage of having the rust layer hold the value so that it could then zero the memory when it was released.
@blu3beri responded to my question on Discord indicating that zeroing the link secret is probably something we want to do but there are some complexities that arise from the fact that it's a BigNumber type from Ursa which doesn't implement zeroize.
The text was updated successfully, but these errors were encountered:
From what I understand, this means that the Python wrapper can pass around a value like the link secret without needing to copy the bytes out of the original buffer. As discussed on Discord, this means that, even though the link secret does need to be passed beyond the FFI boundary at least so the caller can store it in Askar or similar, this can be done in a way that the Rust layer can still effectively zeroize the link secret from memory.
Currently, the anoncreds-rs python wrapper will not accept a memoryview object for the link secret value in methods like process_credential and is strictly expecting a string value.
I raised a question on Discord and it was recommended I raise it as an issue to track here. Original messasge pasted below:
@blu3beri responded to my question on Discord indicating that zeroing the link secret is probably something we want to do but there are some complexities that arise from the fact that it's a BigNumber type from Ursa which doesn't implement zeroize.
The text was updated successfully, but these errors were encountered: