Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master Secret / Link Secret structure #138

Closed
genaris opened this issue Mar 9, 2023 · 1 comment
Closed

Master Secret / Link Secret structure #138

genaris opened this issue Mar 9, 2023 · 1 comment

Comments

@genaris
Copy link
Contributor

genaris commented Mar 9, 2023

Based on our initial experience working with anoncreds-rs in AFJ, I noticed that, when converted from/to JSON, the MasterSecret object has an structure that does not seem related to anything expressed in AnonCreds spec.

It currently follows the form:

 { value: { ms: string } }

I guess this comes from some format used in former Indy SDK, but IMO it should be a plain string, so there would not be need of JSON conversion methods and would be clearer from API perspective.

@genaris
Copy link
Contributor Author

genaris commented Mar 27, 2023

This has been solved by #153

@genaris genaris closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant