Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non revocation proof is not compatible with Ursa #37

Open
conanoc opened this issue Dec 6, 2023 · 4 comments
Open

Non revocation proof is not compatible with Ursa #37

conanoc opened this issue Dec 6, 2023 · 4 comments

Comments

@conanoc
Copy link

conanoc commented Dec 6, 2023

Non revocation proof created using anoncreds-clsignatures-rs cannot be parsed with Ursa.
See this related issue: hyperledger/aries-framework-swift#79

anoncreds-clsignatures-rs does not set m2 on x_list, while m2 is a mandatory field in ursa.

@swcurran
Copy link
Member

This requires a fix to the Indy SDK. The change in the format in the presentation is necessary. As Ursa is archived, and its code migrated to this repo, the change cannot be made in other than the Indy SDK.

It might be possible to code around the issue in the Indy SDK if anyone is interested in taking that path, by altering the presentation to add the extra value required by Ursa.

The (strong) recommendation is to upgrade from the Indy SDK to use the shared components.

@conanoc
Copy link
Author

conanoc commented Dec 12, 2023

I see. Could you tell me a little more about what is m2 and why it is eliminated?

@conanoc
Copy link
Author

conanoc commented Dec 12, 2023

This seems to be the PR that removed m2: #13

@swcurran
Copy link
Member

There was a vulnerability found. We’ll be publishing something about it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants