Use FabricGateway's "asLocalhost" when running discovery service #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcoupelant
requested review from
JeevaSang,
nekia,
nfrunza,
vchinoy-da and
xspeedcruiser
as code owners
Signed-off-by: gcoupelant <[email protected]>
gcoupelant
force-pushed
the
fix/discovery-as-localhost
branch
from
6fb3d78 to
8fdefcf
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
nekia
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Thanks @gcoupelant , You're definitely right. It's good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documented variable
DISCOVERY_AS_LOCALHOSTseems to ignored when running discovery service.The
asLocalhostoption is hardcoded totrue.This PR makes the discovery service use the value configured during
initialize()