Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the pre-commit hooks #4141

Open
DCNick3 opened this issue Dec 12, 2023 · 0 comments
Open

Update the pre-commit hooks #4141

DCNick3 opened this issue Dec 12, 2023 · 0 comments
Labels
CI Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@DCNick3
Copy link
Contributor

DCNick3 commented Dec 12, 2023

Currently, the pre-commit hook still uses cargo lints, which should not be used since the merge of #3904.

It also hard-codes the use of +nightly toolchain, while it should ideally be specified as a concrete version in rust-toolchain.toml to match the version we use in CI.
@DCNick3 DCNick3 added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST CI labels Dec 12, 2023
@DCNick3 DCNick3 mentioned this issue Dec 12, 2023
Merged
@mversic mversic added this to Iroha Oct 10, 2024
@mversic mversic moved this to Backlog in Iroha Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DCNick3