Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper IPFS logo mutator #1994

Closed
appetrosyan opened this issue Mar 22, 2022 · 5 comments
Closed

Add proper IPFS logo mutator #1994

appetrosyan opened this issue Mar 22, 2022 · 5 comments
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@appetrosyan
Copy link
Contributor

No description provided.

@appetrosyan appetrosyan added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Mar 22, 2022
@appetrosyan appetrosyan mentioned this issue Mar 22, 2022
Merged
@mversic
Copy link
Contributor

mversic commented Mar 22, 2022

Should logo be allowed to be constructed with NewDomain if it can be mutated with instructions?

@appetrosyan
Copy link
Contributor Author

I think we should be able to mutate the logo with an instruction, I'm just not too keen on adding an instruction just to edit the logo.

@appetrosyan appetrosyan added the Enhancement New feature or request label May 19, 2022
@appetrosyan appetrosyan added Chore This is a small task that can be done at any point in time and is easier than others and removed Chore This is a small task that can be done at any point in time and is easier than others labels Jun 8, 2022
@mversic
Copy link
Contributor

mversic commented Aug 23, 2023

would be irrelevant if we make logo as metadata value

@mversic
Copy link
Contributor

mversic commented Dec 7, 2023

let's change the scope of this ticket to make logo a metadata value, not a field in the Domain struct

@mversic
Copy link
Contributor

mversic commented Jan 24, 2024

closed in favor of #4230

@mversic mversic closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@appetrosyan @mversic