Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss Clippy configuration #9

Open
1 of 4 tasks
6r1d opened this issue Sep 12, 2023 · 2 comments
Open
1 of 4 tasks

Discuss Clippy configuration #9

6r1d opened this issue Sep 12, 2023 · 2 comments
Assignees

Comments

@6r1d
Copy link
Contributor

6r1d commented Sep 12, 2023

The original tutorial file contains this line:

#![allow(clippy::restriction, clippy::needless_borrow)]

There's another Clippy config at million_accounts_genesis:

#![allow(missing_docs, clippy::pedantic, clippy::restriction)]

I'm not sure how important Clippy configuration is for the examples, and I have to return to this after I move the tests.

Feature list

Since I'm not sure what each part does, I'll add links and discuss the other parts below.

@6r1d 6r1d self-assigned this Sep 12, 2023
@6r1d
Copy link
Contributor Author

6r1d commented Sep 12, 2023

For now, I'm trying to understand whether these lines

allow = [
    # We don't want to manually deny every `clippy::restriction::*` lint.
    'clippy::blanket-clippy-restriction-lints',
]

match this code

#![allow(clippy::restriction)]

@6r1d
Copy link
Contributor Author

6r1d commented Sep 12, 2023

Current Clippy lints are configured here: https://github.com/hyperledger/iroha/blob/iroha2-dev/lints.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant