Provide cli command to spawn a distributed worker #734
Conversation
nklincoln
requested review from
aklenik,
feihujiang,
jiangyaoguo,
liam-grace and
panyu4
as code owners
nklincoln
force-pushed
the
spawn-client-cli
branch
2 times, most recently
from
7b2a147 to
bb149ad
Compare
|
|
||
| let sutList = Object.keys(bindOptions.sut); | ||
| if (!sut) { | ||
| let msg = `SUT name is not specified. Available SUTs: ${sutList.join(' | ')}`; | ||
| let msg = `SUT name is not specified. Available SUTs: ${Object.keys(defaultBindOpts.sut).join(' | ')}`; |
There was a problem hiding this comment.
Shouldn't we list the SUT names available in the set config file (not necessarily the default)?
So ${Object.keys(bindOptions.sut).join(' | ')} or simply ${sutList.join(' | ')}
Same for the other error messages.
There was a problem hiding this comment.
this was an attempt to try and protect us from someone passing in an incorrect file - if it is completely wrong, then we won't be able to list anything.
Which raises the question on the need for a validator here
There was a problem hiding this comment.
Yeah, a validator is definitely needed. Then let's leave it as it is for now.
| }); | ||
| yargs.usage('Usage:\n caliper bind --caliper-bind-sut fabric --caliper-bind-sdk 1.4.1 --caliper-bind-cwd ./ --caliper-bind-args="-g"'); | ||
|
|
||
| // enforce the option after these options | ||
| yargs.requiresArg(['caliper-bind-sut','caliper-bind-sdk','caliper-bind-args', 'caliper-bind-cwd']); |
There was a problem hiding this comment.
Hmm, the requiresArg call has been removed from our run command, so the options can also be specified from other sources (env, config file, etc). Strange how this line didn't cause a problem so far....
There was a problem hiding this comment.
the above are the required items as per the bind configuration only - which iirc also complains if the items are not passed. But you are correct - this is essentially a run command, so we should map to that pattern and only throw/reject if there are no values at the point of use
nklincoln
force-pushed
the
spawn-client-cli
branch
4 times, most recently
from
9dfbec4 to
69572d4
Compare
…cess comms method Signed-off-by: [email protected] <[email protected]>
nklincoln
force-pushed
the
spawn-client-cli
branch
from
69572d4 to
6625b71
Compare
CLI command to spawn a worker that uses a non-process comms method
Changes include:
closes #697
Signed-off-by: [email protected] [email protected]