Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation and doc comment in prometheus observer #1456

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

CaptainIRS
Copy link
Contributor

  • Fixed histogram calculation
  • Fixed doc comment in test utility class

* Fixed histogram calculation
* Fixed doc comment in test utility class

Signed-off-by: CaptainIRS <[email protected]>
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #1456 (c297544) into main (69000d4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1456   +/-   ##
=======================================
  Coverage   55.56%   55.56%           
=======================================
  Files         103      103           
  Lines        4451     4451           
  Branches      676      676           
=======================================
  Hits         2473     2473           
  Misses       1435     1435           
  Partials      543      543           
Flag Coverage Δ
caliper-core 44.31% <100.00%> (ø)
caliper-fabric 80.46% <ø> (ø)
generator-caliper 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...worker/tx-observers/prometheus-push-tx-observer.js 74.19% <100.00%> (ø)
.../lib/worker/tx-observers/prometheus-tx-observer.js 69.69% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit 1eade51 into hyperledger-caliper:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants