Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage report workflow #1428

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

CaptainIRS
Copy link
Contributor

In this PR:

  • A step which reports coverage to Codecov is added to the unit tests workflow

Fixes #1278

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@c648fa9). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1428   +/-   ##
=======================================
  Coverage        ?   55.56%           
=======================================
  Files           ?      103           
  Lines           ?     4451           
  Branches        ?      676           
=======================================
  Hits            ?     2473           
  Misses          ?     1435           
  Partials        ?      543           
Flag Coverage Δ
caliper-core 44.31% <0.00%> (?)
caliper-fabric 80.46% <0.00%> (?)
generator-caliper 83.62% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CaptainIRS CaptainIRS force-pushed the coverage-reports branch 5 times, most recently from f1df9cb to b51445d Compare August 5, 2022 02:19
@CaptainIRS CaptainIRS changed the title Add coverage report step to unit tests workflow Add coverage report workflow Aug 5, 2022
runs-on: ubuntu-latest
strategy:
matrix:
package: [caliper-core, caliper-fabric, generator-caliper]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not want all the other packages ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because we're running unit tests only for these packages (since only these packages have unit tests). Most other packages simply run the linter when npm test is run, so we wouldn't have coverage information.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we missing some packages ?

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit 2cdd46d into hyperledger-caliper:main Aug 5, 2022
eravatee pushed a commit to eravatee/caliper that referenced this pull request Oct 1, 2022
eravatee pushed a commit to eravatee/caliper that referenced this pull request Oct 4, 2022
eravatee pushed a commit to eravatee/caliper that referenced this pull request Oct 4, 2022
eravatee pushed a commit to eravatee/caliper that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code coverage reporting integrated into the build
2 participants