-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage report workflow #1428
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
=======================================
Coverage ? 55.56%
=======================================
Files ? 103
Lines ? 4451
Branches ? 676
=======================================
Hits ? 2473
Misses ? 1435
Partials ? 543
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
f1df9cb
to
b51445d
Compare
Signed-off-by: CaptainIRS <[email protected]>
b51445d
to
8bb9240
Compare
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
package: [caliper-core, caliper-fabric, generator-caliper] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not want all the other packages ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because we're running unit tests only for these packages (since only these packages have unit tests). Most other packages simply run the linter when npm test
is run, so we wouldn't have coverage information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we missing some packages ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: CaptainIRS <[email protected]> Signed-off-by: eravatee <[email protected]>
Signed-off-by: CaptainIRS <[email protected]> Signed-off-by: eravatee <[email protected]>
Signed-off-by: CaptainIRS <[email protected]> Signed-off-by: eravatee <[email protected]>
Signed-off-by: CaptainIRS <[email protected]> Signed-off-by: eravatee <[email protected]>
In this PR:
Fixes #1278