Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus configuration isn't quite right #884

Closed
nklincoln opened this issue Jun 26, 2020 · 0 comments · Fixed by #943
Closed

Prometheus configuration isn't quite right #884

nklincoln opened this issue Jun 26, 2020 · 0 comments · Fixed by #943
Labels
component/core Related to the core code-base enhancement New feature or request

Comments

@nklincoln
Copy link
Contributor

Currently the Prometheus implementation is not quite right

  • the monitor should only ever relate to the Prometheus server where queries are made
  • selection of the TPS stats should be made under the worker definition not as part of the monitor definition

It should be possible to disambiguate between using a local transaction statistics, and those drawn from prometheus. And not be forced into using Prometheus derived transaction stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/core Related to the core code-base enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add txObservers and make use of TXN Stats Collector object nklincoln/caliper
1 participant
@nklincoln