Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide simpler Prometheus metrics in worker clients #637

Closed
aklenik opened this issue Nov 5, 2019 · 0 comments
Closed

Provide simpler Prometheus metrics in worker clients #637

aklenik opened this issue Nov 5, 2019 · 0 comments
Assignees
Labels
component/core Related to the core code-base enhancement New feature or request priority
Milestone

Comments

@aklenik
Copy link
Contributor

aklenik commented Nov 5, 2019

Context

The worker clients provide some aggregated metrics related to the TXs since the last push/update. This is not the Prometheus way, as the Prometheus queries usually specify their own aggregation window.

Expected Behavior

Specify only the following metrics:

  • caliper_tx_submitted: counter, incremented when submitCallback is called, with the client id as a label.
  • caliper_tx_finished: counter, incremented when the callback returns the result array, with the client ID and final status (success/failed) as labels
  • caliper_tx_e2e_latency: histogram, updated when caliper_tx_finished is updated (histograms are cheap on the client-side, unlike summaries)

A number of metrics may be derived from the above using Prometheus queries, like goodput, failure rate, total TPS (successful and failed), sending TPS and pending transactions. With little to no performance cost for the worker clients.

Actual Behavior

Metrics are locally aggregated, then pushed.

Your Environment

  • Version used: 0.2.0
@aklenik aklenik added enhancement New feature or request component/core Related to the core code-base labels Nov 5, 2019
@aklenik aklenik added this to the v0.3.0 milestone Nov 5, 2019
@nklincoln nklincoln self-assigned this May 1, 2020
@aklenik aklenik modified the milestones: v0.3.0, v0.4.0 May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to the core code-base enhancement New feature or request priority
Projects
None yet
Development

No branches or pull requests

2 participants