Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the Fabric CCP adapter #467

Closed
6 tasks
aklenik opened this issue May 30, 2019 · 1 comment
Closed
6 tasks

Clean up the Fabric CCP adapter #467

aklenik opened this issue May 30, 2019 · 1 comment
Assignees
@aklenik
Labels
enhancement New feature or request locked Someone is already working on it
Milestone
Future release

Comments

@aklenik
Copy link
Contributor

aklenik commented May 30, 2019

Context

The adapter currently relies on the FabricNetwork module for network information which is intended for the user modules and breaks the code flow (and code completion support) in the adapter.

Possible Fix

The adapter should process the network configuration file directly, treating the sections as self-contained objects.

Progress of the refactoring

  • Extract the network validation into a separate util module
  • Separate the user/admin/registrar initialization from the FabricNetwork module
  • Separate the channel creation from the FabricNetwork module
  • Separate the channel joining from the FabricNetwork module
  • Separate the chaincode installation from the FabricNetwork module
  • Separate the chaincode instantiation from the FabricNetwork module
@aklenik aklenik added the enhancement New feature or request label May 30, 2019
@aklenik aklenik self-assigned this May 30, 2019
@aklenik aklenik added the locked Someone is already working on it label May 30, 2019
@aklenik aklenik mentioned this issue Sep 30, 2019
Merged
@aklenik aklenik added this to the Future release milestone Nov 7, 2019
@nklincoln
Copy link
Contributor

Superseded by #940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aklenik aklenik

Labels
enhancement New feature or request locked Someone is already working on it
Projects
None yet
Milestone
Future release
Development

No branches or pull requests
2 participants
@nklincoln @aklenik