Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The fabric-ccp don't have network file for fabric-v1.3/v1.4. I want to use fabric-v1.3/1.4 to test adapters' fabric-ccp and fabric #396

Closed
3 tasks
clumsky opened this issue Apr 1, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@clumsky
Copy link
Contributor

clumsky commented Apr 1, 2019

@aklenik

Context

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Existing issues

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop or mobile):
  • Link to your project:
    clients in fabric-ccp.yaml file #393
@aklenik
Copy link
Contributor

aklenik commented Apr 1, 2019

@clumsky You're right, we'll add them once an ongoing restructuring of the project is done. But you can use any v1.1 example file, just make sure that you change the start/end scripts to point to the correct docker-compose file. I think no other changes are required.

@aklenik aklenik added the enhancement New feature or request label Apr 1, 2019
@clumsky
Copy link
Contributor Author

clumsky commented Apr 2, 2019

I want to merge src/adapters/fabric into src/adapters/fabirc-ccp in fabric-v1.3 and v1.4. But now fabric-ccp
don't have network file for fabric-v1.3/v1.4.

@aklenik
Copy link
Contributor

aklenik commented Apr 2, 2019

@clumsky What do you mean by merge?

@clumsky
Copy link
Contributor Author

clumsky commented Apr 2, 2019

Add src/adapters/fabric some function modules(like:Add a transactions' file generation mode.#286) to src/adapters/fabric-ccp.

@aklenik
Copy link
Contributor

aklenik commented Apr 3, 2019

@clumsky Well, the design of the two adapters is fundamentally different, so migrating the tx mode functionality will not be trivial, possible it'll need to be implemented cleanly from scratch in the CCP adapter.

If you're working on this feature migration, I'd suggest you wait for some other refactoring job to be finished (like the whole project restructuring going on right now, plus I'm adding Solidity support to the CCP adapter). And message me on Rocker.Chat (klenik) so the implementation goes more smoothly.

@nklincoln
Copy link
Contributor

closing due to existence of *-ccp network 1.4 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants