Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions when running unit tests are not failing #1660

Open
davidkel opened this issue Nov 21, 2024 · 1 comment
Open

github actions when running unit tests are not failing #1660

davidkel opened this issue Nov 21, 2024 · 1 comment
Labels
bug Something isn't working build

Comments

@davidkel
Copy link
Contributor

Some tests which fail when run in 18.x, 20.x, 22.x resulted in the following

image

which shows 18.x failed, but the other 2 reported as succeeded
A quick test shows that on 20.x npm run tests --workspaces results in a RC of 1 ($?) if a test fails and RC or 0 if all tests pass so why is github actions thinking it hasn't failed but not for all in the matrix ?

@davidkel davidkel added bug Something isn't working build labels Dec 10, 2024
@Veer0x1
Copy link

Veer0x1 commented Dec 29, 2024

@davidkel can you explain this issue in little more details? I tried to run this workflow on my fork, it passes for all the matrix
Screenshot 2024-12-30 at 2 19 13 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build
Projects
None yet
Development

No branches or pull requests

2 participants