Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the publish step to Github Actions #1369

Closed
davidkel opened this issue Jun 13, 2022 · 2 comments · Fixed by #1384
Closed

Migrate the publish step to Github Actions #1369

davidkel opened this issue Jun 13, 2022 · 2 comments · Fixed by #1384
Assignees
Labels
build enhancement New feature or request

Comments

@davidkel
Copy link
Contributor

davidkel commented Jun 13, 2022

This will require help from the Hyperledger Foundation as they own the npm and docker push secrets, As part of this we will need to also disable the azure pipelines publish to ensure only one build pipeline performs the publish step
This is dependent on #1368 being completed first

@davidkel davidkel added enhancement New feature or request build labels Jun 13, 2022
@davidkel
Copy link
Contributor Author

FYI:
OK. Here are the ones you need (and have): DOCKERHUB_ORG, DOCKERHUB_TOKEN, DOCKERHUB_USERNAME, NPM_TOKEN
Here is how :iroha: uses them: https://github.com/hyperledger/iroha/blob/9af9a2f64008a5224c17440c681894b758de4b35/.github/workflows/iroha2-push-nightly.yml

Also note that to be consistent we should still perform the unit test runs before doing a merge as this is what the azure pipelines currently does. There is an issue under the optimize theme that covers looking into why this was done (I don't know but @aklenik may know) see #1380

@CaptainIRS
Copy link
Contributor

I think the tokens haven't been added to the repository yet as the workflow failed in the main branch due to the missing NPM_TOKEN variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants