Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default.yaml comment improvements #1284

Closed
davidkel opened this issue Mar 23, 2022 · 1 comment · Fixed by #1306
Closed

default.yaml comment improvements #1284

davidkel opened this issue Mar 23, 2022 · 1 comment · Fixed by #1306
Assignees
@fraVlaca
Labels
bug Something isn't working documentation Related to the documentation enhancement New feature or request
Milestone
v0.5.0

Comments

@davidkel
Copy link
Contributor

davidkel commented Mar 23, 2022 •
edited
Loading

default.yaml (packages/caliper-core/lib/common/config/default.yaml) is referenced by documentation so we should make the comments more descriptive especially the fabric ones due to them not working with all connectors, plus can remove the countqueryasload entry as it's not a valid option anymore.
@davidkel davidkel added enhancement New feature or request bug Something isn't working documentation Related to the documentation and removed enhancement New feature or request labels Mar 23, 2022
@davidkel davidkel added this to the v0.5.0 milestone Mar 23, 2022
@davidkel davidkel added the enhancement New feature or request label Mar 24, 2022
@davidkel davidkel mentioned this issue Apr 2, 2022
Closed
@davidkel davidkel linked a pull request Apr 8, 2022 that will close this issue
Fixes for default.yaml in packages/caliper-core/lib/common/config/ and updates for the fabric Channel operations for the v1 fabric connector #1306
Merged
@davidkel
Copy link
Contributor Author

davidkel commented Apr 8, 2022

Addressed by #1306, closing

@davidkel davidkel closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fraVlaca fraVlaca

Labels
bug Something isn't working documentation Related to the documentation enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
2 participants
@davidkel @fraVlaca