Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative send rate can be observed in reports #1044

Closed
nklincoln opened this issue Oct 8, 2020 · 2 comments · Fixed by #1045
Closed

Negative send rate can be observed in reports #1044

nklincoln opened this issue Oct 8, 2020 · 2 comments · Fixed by #1045
Assignees
Labels
bug Something isn't working component/core Related to the core code-base priority

Comments

@nklincoln
Copy link
Contributor

nklincoln commented Oct 8, 2020

In some instances it is possible to observe a negative send rate in the reports.

This appears to occur in short round durations, and a quick set of logging in the report generation side (within getResultValues) reveals that there may be any issue in the txUpdate phase, since:

results.getFirstCreateTime() 1602161955354
results.getLastCreateTime()  1602161954519

At no point should the last create time be less than the first create time.

@nklincoln nklincoln added bug Something isn't working component/core Related to the core code-base labels Oct 8, 2020
@aklenik
Copy link
Contributor

aklenik commented Oct 8, 2020

I think this is the problem:
https://github.com/hyperledger/caliper/blob/363a6ddf34f084dbd9a54cdc08e21413d521f843/packages/caliper-core/lib/common/core/transaction-statistics-collector.js#L330-L334
firstCreateTime is calculated from firstFinishTime during stat merge 😅

@nklincoln
Copy link
Contributor Author

confirmed above, by locally fixing code and re-running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/core Related to the core code-base priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants