Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): improve error message for invalid compression flag #663

Merged
merged 2 commits into from
May 28, 2021
+2 −2
Merged

fix(codec): improve error message for invalid compression flag #663

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca1651d
fix(codec): improve error message for invalid compression flag
davidpdrsn May 23, 2021
6f2e8aa
Update tonic/src/codec/decode.rs
davidpdrsn May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tonic/src/codec/decode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,11 @@ impl<T> Streaming<T> {
trace!("unexpected compression flag");
let message = if let Direction::Response(status) = self.direction {
format!(
"Unexpected compression flag: {}, while receiving response with status: {}",
"protocol error: received message with invalid compression flag: {} (valid flags are 0 and 1) while receiving response with status: {}",
f, status
)
} else {
format!("Unexpected compression flag: {}, while sending request", f)
format!("protocol error: received with message with invalid compression flag: {} (valid flags are 0 and 1), while sending request", f)
};
return Err(Status::new(Code::Internal, message));
}
Expand Down