-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge trailer and inital headers into status on err #510
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++ gRPC server sometimes returns both headers and trailers. An excerpt from Wireshark: ``` Stream: HEADERS, Stream ID: 1, Length 136, 200 OK Header: :status: 200 OK Header: x-middleware: expected value Header: content-type: application/grpc Header: grpc-accept-encoding: identity,deflate,gzip Header: accept-encoding: identity,gzip Stream: HEADERS, Stream ID: 1, Length 92 Header: grpc-status: 2 Header: grpc-message: Unknown Header: x-arrow-status: 9 Header: x-arrow-status-message-bin: VW5rbm93bg ``` Before this commit, only the metadata from the trailer would be available, missing the `x-middleware` header: ``` MetadataMap { headers: { "x-arrow-status-message-bin": "VW5rbm93bg", "x-arrow-status": "9", }, } ```
Talking with @LucioFranco in Discord, it seems like it's very hard (impossible?) to cause Tonic to perform the same behavior of sending separate headers and trailers, so it's not clear how best to write a test for this at this point. |
LucioFranco
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
nevi-me
pushed a commit
to apache/arrow
that referenced
this pull request
Jan 9, 2021
This PR has a few refactorings and then the main commit contains a new Flight integration test client and server 🎉 The middleware scenario tests are currently skipped because they will fail until `tonic` can be updated to a version containing [a fix having to do with trailers](hyperium/tonic#510); this is tracked in [ARROW-10961](https://issues.apache.org/jira/browse/ARROW-10961). Some Rust <-> Java integration tests will fail until [this PR is merged](#8963); I'm happy to rebase once that goes in, but I wanted to get code review started on this. Thank you!! Closes #9049 from carols10cents/rust-flight-integration Lead-authored-by: Carol (Nichols || Goulding) <[email protected]> Co-authored-by: Jake Goulding <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
This was referenced Mar 18, 2021
Closed
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
This PR has a few refactorings and then the main commit contains a new Flight integration test client and server 🎉 The middleware scenario tests are currently skipped because they will fail until `tonic` can be updated to a version containing [a fix having to do with trailers](hyperium/tonic#510); this is tracked in [ARROW-10961](https://issues.apache.org/jira/browse/ARROW-10961). Some Rust <-> Java integration tests will fail until [this PR is merged](apache/arrow#8963); I'm happy to rebase once that goes in, but I wanted to get code review started on this. Thank you!! Closes #9049 from carols10cents/rust-flight-integration Lead-authored-by: Carol (Nichols || Goulding) <[email protected]> Co-authored-by: Jake Goulding <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
GeorgeAp
pushed a commit
to sirensolutions/arrow
that referenced
this pull request
Jun 7, 2021
This PR has a few refactorings and then the main commit contains a new Flight integration test client and server 🎉 The middleware scenario tests are currently skipped because they will fail until `tonic` can be updated to a version containing [a fix having to do with trailers](hyperium/tonic#510); this is tracked in [ARROW-10961](https://issues.apache.org/jira/browse/ARROW-10961). Some Rust <-> Java integration tests will fail until [this PR is merged](apache#8963); I'm happy to rebase once that goes in, but I wanted to get code review started on this. Thank you!! Closes apache#9049 from carols10cents/rust-flight-integration Lead-authored-by: Carol (Nichols || Goulding) <[email protected]> Co-authored-by: Jake Goulding <[email protected]> Signed-off-by: Neville Dipale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The C++ gRPC server sometimes returns both headers and trailers. An
excerpt from Wireshark:
Before this commit, only the metadata from the trailer would be
available, missing the
x-middleware
header:Solution
Merge the metadata before returning the error