Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily allow duplicate crossbeam-queue crates #153

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Nov 25, 2019

crossbeam-queue is currently brought in both by Rayon (up to date v0.2.0) and Hyper's dependency chain (0.1.x). Since Hyper is in the process of updating things, I proposed we temporarily allow this to pass CI and revisit it when there is a new release of Hyper or the relevant dependencies thereof.

This will fix the build of #151, #148 etc.

`crossbeam-queue` is currently brought in both by Rayon (up to date v0.2.0) and
Hyper's dependency chain (0.1.x). Since Hyper is in the process of updating
things, I proposed we temporarily allow this to pass CI and revisit it when
there is a new release of Hyper or the relevant dependencies thereof.
@LucioFranco LucioFranco merged commit 33df3ba into master Nov 25, 2019
@LucioFranco LucioFranco deleted the jen20/temp-allow-duplicate-crossbeam branch November 25, 2019 21:18
@LucioFranco
Copy link
Member

Thanks!

zenria pushed a commit to zenria/tonic that referenced this pull request Dec 6, 2019
* master:
  Upgrade to `tokio 0.2` (hyperium#163)
  chore(interop): Update console dep (hyperium#155)
  Temporarily allow duplicate crossbeam-queue crates (hyperium#153)

# Conflicts:
#	tonic/src/transport/server.rs
rabbitinspace pushed a commit to satelit-project/tonic that referenced this pull request Jan 1, 2020
`crossbeam-queue` is currently brought in both by Rayon (up to date v0.2.0) and
Hyper's dependency chain (0.1.x). Since Hyper is in the process of updating
things, I proposed we temporarily allow this to pass CI and revisit it when
there is a new release of Hyper or the relevant dependencies thereof.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants