Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thrown? is not resolved in cljs #54

Open
ggeoffrey opened this issue Jun 8, 2022 · 1 comment
Open

thrown? is not resolved in cljs #54

ggeoffrey opened this issue Jun 8, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@ggeoffrey
Copy link
Member

(ns foo
  (:require [hyperfiddle.rcf :refer [tests]]))

(tests
  (inc nil) thrown? NullPointerException)

Compiler warning:

Use of undeclared Var foo/thrown?

thrown? is defined by t/assert-expr, it should not be resolved in the current ns if used in an assertion.

@ggeoffrey ggeoffrey added the bug Something isn't working label Jun 8, 2022
@ggeoffrey ggeoffrey self-assigned this Jun 8, 2022
@dustingetz
Copy link
Member

dustingetz commented Jun 8, 2022

I propose to rename thrown? to throws? or even :throws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants