Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line.Trim(Polygon) does not trim correctly with concave polygons. #355

Closed
ikeough opened this issue Jul 31, 2020 · 3 comments · Fixed by #356
Closed

Line.Trim(Polygon) does not trim correctly with concave polygons. #355

ikeough opened this issue Jul 31, 2020 · 3 comments · Fixed by #356
Labels
Bug Something isn't working Geometry
Milestone
0.7.3

Comments

@ikeough
Copy link
Contributor

ikeough commented Jul 31, 2020 •
edited
Loading

Describe the bug
Line.Trim(Polygon) does not work for concave polygons.

Screenshots
Neither the inner or the outer settings work.
image
image
@ikeough ikeough added this to the 0.7.3 milestone Jul 31, 2020
@ikeough ikeough added the Bug Something isn't working label Jul 31, 2020
@andrewheumann
Copy link
Member

The algorithm seems to handle concave polygons just fine -- the issue may be something else. Can you provide a set of test polygon + lines that were failing?
image

@andrewheumann
Copy link
Member

It looks like your lines start from on the polygon edges - is that true? that may have something to do with it

@andrewheumann andrewheumann mentioned this issue Jul 31, 2020
Merged
@ikeough
Copy link
Contributor Author

ikeough commented Jul 31, 2020

That is true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Geometry
Projects
None yet
Milestone
0.7.3
Development

Successfully merging a pull request may close this issue.

Fix line trim when line begins on polygon edge andrewheumann/Elements
2 participants
@ikeough @andrewheumann