Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

[Select] not working on Android #311

Closed
harwall opened this issue Aug 19, 2020 · 6 comments
Closed

[Select] not working on Android #311

harwall opened this issue Aug 19, 2020 · 6 comments

Comments

@harwall
Copy link

harwall commented Aug 19, 2020

Describe the bug
The select feature works perfectly on IOS but I simply can't get it to work on Android.

I can open and close it but nothing happens when I click on an option. Once again, it's working perfectly on ios.

To Reproduce
I followed the instructions as written here : https://github.com/dooboolab/dooboo-ui/tree/master/main/Select

And this is my code.

import {Select, SelectItem} from 'dooboo-ui';
import React from 'react';
import {useState} from 'react';

import styled from 'styled-components/native';

/** COMPONENTS */
const CustomSelectContainer = styled.View`
  width: 100%;
  height: 50px;
  justify-content: center;
  background-color: white;
  border-radius: 4px;
  elevation: 5;
  box-shadow: 0px 1px 1px #b3b3b3;
  shadow-opacity: 0.4;
  shadow-radius: 1px;
  margin-top: 50px;
`;

export function ExamplePage() {
  const [selectedValue, onSelectedValue] = useState<string>('En');
  const [isOpen, toggleSelect] = useState<boolean>(false);

  return (
    <CustomSelectContainer>
      <Select
        opened={isOpen}
        loading={false}
        disabled={false}
        showArrow={true}
        bordered={true}
        value={selectedValue}
        onSelect={(value): void => onSelectedValue(value)}
        onOpen={(isOpen): void => toggleSelect(isOpen)}>
        <SelectItem value="english">english</SelectItem>
        <SelectItem value="français">français</SelectItem>
        <SelectItem value="deutsch">deutsch</SelectItem>
      </Select>
    </CustomSelectContainer>
  );
}

Expected behavior
When on Android, on click on an option/SelectItem, the select should close itself and show the selected value.

Smartphone (please complete the following information):

  • Device: Pixel 2, emulated on android studio
  • OS: Android, don't know the version

It's been tested on other devices by some of my colleagues and they also got the issue on Android.

Is there anyone who got the same issue or who knows the answer ? I'm kinda getting desperate :/

@JeffGuKang JeffGuKang added the bug label Aug 20, 2020
@JongtaekChoi
Copy link
Collaborator

JongtaekChoi commented Aug 20, 2020

This issue related to this issue. If select items are visible, those are out of the parent view(Container of the Select) and it's not touchable now at the android platform. And related pr is waiting for merge. Regardless of this, we are trying to fix it as well in another way.

@harwall
Copy link
Author

harwall commented Aug 20, 2020

Thanks for the answer. By any chance do you have the link to the pr waiting for merge ?

@JongtaekChoi
Copy link
Collaborator

The pr is here.

@harwall
Copy link
Author

harwall commented Aug 21, 2020

Thanks a lot !

@JeffGuKang JeffGuKang changed the title Select not working on Android [Select] not working on Android Sep 13, 2020
@stale
Copy link

stale bot commented Dec 12, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale label Dec 12, 2020
@stale
Copy link

stale bot commented Jan 16, 2021

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants