Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix neglected ci for code quality #1398

Closed
gilch opened this issue Aug 25, 2017 · 2 comments
Closed

fix neglected ci for code quality #1398

gilch opened this issue Aug 25, 2017 · 2 comments

Comments

@gilch
Copy link
Member

gilch commented Aug 25, 2017

We don't seem to be running flake8 and coverage anymore, but maybe I'm reading the logs wrong. Why did we stop? I don't think it was on purpose, or they wouldn't still be in requirements-travis.txt. We also need to add something like parlinter to our ci, to enforce a basic level of legibility in the .hy files. Indentation is all over the place, which can make them really hard to read. See also #972.

@Kodiologist
Copy link
Member

Why did we stop?

It looks like I forgot to add back flake8 when I redid the Travis configuration for pytest. As for Coveralls, that seems to have stopped running in 2014, which is before my time.

@Kodiologist
Copy link
Member

Can't say I miss it. Code quality has improved over the past 5 years, partly from not having to appease linters. I've seen for myself that this project isn't immune to the tendency of programmers to treat linters as authorities to be obeyed unquestioningly, rather than tools. Let's not backslide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants