Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyfetch installed by pip does not recognize Git for Windows installed by scoop #83

Closed
1 task done
Namorzyny opened this issue Jan 27, 2023 · 2 comments
Closed
1 task done

Comments

@Namorzyny
Copy link

Description

Because of hard coded path of Git for Windows, hyfetch can not recognize other situations like the portable version or a custom installation path, or as the title says.

def ensure_git_bash() -> Path:

  • Does this issue still occur in the master branch? (Required if issue)

Neofetch version

7.3.6

@hykilpikonna
Copy link
Owner

This is fixed by #87

@teohhanhui
Copy link
Contributor

In the process of porting the Python code to Rust (#317), I've found that 5c34876 has reintroduced this bug?

The paths used to find bash are hardcoded again... But I understand that we can't try to find bash.exe in PATH too thanks to #233 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants