Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered room is filled with my username when I go back from the page Settings #41

Open
antoyo opened this issue Dec 30, 2023 · 11 comments · May be fixed by element-hq/hydrogen-web#1200
Open
Labels
bug Something isn't working upstream

Comments

@antoyo
Copy link

antoyo commented Dec 30, 2023

Hi.
The following actions will fill the "Filter rooms..." input text with my username:

  • Click on the Settings icon.
  • Click on back to go back to the list of conversations.

I would expect the input text to not be filled.

I don't know if this is an issue with upstream of the SailfishOS port.

Thanks.

@b100dian
Copy link
Contributor

Hi, thank you for your bug report.
I recall to have noticed this while at the November hackathon, however I do not see it now, not on my device and nor on https://hydrogen.element.io which also runs 0.4.1 today.
Are you able to reproduce it on a desktop browser too?

@b100dian b100dian added bug Something isn't working upstream labels Dec 31, 2023
@antoyo
Copy link
Author

antoyo commented Dec 31, 2023

No. I cannot reproduce in my desktop browser.
Should I try on Firefox or Chrome to mimic most closely the app?

I have hydrogen-sailfishos 0.4.1+master on a Sony Xperia XA2 with SailfishOS version 4.5.0.24.

@b100dian
Copy link
Contributor

I think Firefox with a very narrow window..
But thanks for stating that you're running the latest, I am sure we'll find a way to repro it again - @pherjung maybe you have seen it too? If not, we can check the upstream source.
Initial grepping doesn't show much on "room-filter" other than the fact that autocomplete is on. Maybe this happens only in the session you initially log in, and username is retained by the browser?

@antoyo
Copy link
Author

antoyo commented Dec 31, 2023

The issue doesn't happen in Firefox either. Any other thing I could test?

@pherjung
Copy link
Contributor

pherjung commented Jan 3, 2024

Yes, I already noticed this issue. I don't know where is the bug, but if I find something I'll comment here.

@yajo10
Copy link
Collaborator

yajo10 commented Jan 5, 2024

It suddenly is reproduce able for me now as well.

@b100dian
Copy link
Contributor

b100dian commented Jan 8, 2024

Is this with an user name (as in, lowercase etc.) or with a Name (which may have the first letter uppercased)? I ask to determine if there's a name clash with the login field (in which case one should remember if Save password was used) or just an application bug.

@pherjung
Copy link
Contributor

pherjung commented Jan 8, 2024

Strangely, I haven't been able to figure out how to reproduce this bug. At the moment it looks really random.

@antoyo
Copy link
Author

antoyo commented Jan 8, 2024

Is this with an user name (as in, lowercase etc.) or with a Name (which may have the first letter uppercased)? I ask to determine if there's a name clash with the login field (in which case one should remember if Save password was used) or just an application bug.

It's the username (lowercase).

@ichthyosaurus
Copy link
Collaborator

I have multiple accounts and in my case it is actually the username (lowercase) of the first account: if my accounts are "jim", "john", "jane", then it is always "jim" no matter which account I used to open the settings page.

@ichthyosaurus
Copy link
Collaborator

This is element-hq/hydrogen-web#380. I proposed a fix in element-hq/hydrogen-web#1200.

@ichthyosaurus ichthyosaurus mentioned this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants