Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKAttributes+PositionConstraints initializer typo? #131

Closed
jgoodrick opened this issue Oct 26, 2018 · 4 comments
Closed

EKAttributes+PositionConstraints initializer typo? #131

jgoodrick opened this issue Oct 26, 2018 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@jgoodrick
Copy link
Contributor

Describe the bug
The currently provided default initializer does not actually use the passed in max size, ignoring it during initialization.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'EKAttributes+PositionConstraints.swift'
  2. Scroll down to 'public init(verticalOffset:size:maxSize:)'
  3. See error:
    self.maxSize = .intrinsic

Expected behavior
I would have expected the third line to read:
self.maxSize = maxSize

iPhone (please complete the following information):

  • Device: iPhoneX
  • iOS Version: iOS12
  • Xcode Version 10.0
  • Dependency Manager Version: CocoaPods 1.5.3
  • SwiftEntryKit Release # 0.8.2
@jgoodrick
Copy link
Contributor Author

Seems like an easy fix, is there something I can do to make it easier for you? I have never actually contributed to a project before, but it would seem like if you agree this should be fixed, then I should fork the project, fix it, and then open a pull request, right? Sorry, I'm kind of new to all of this open source stuff.

@huri000
Copy link
Owner

huri000 commented Oct 27, 2018

Hi @sndrsn! My bad, thanks for letting me know!
You are always welcome to fork and pull request fixes for bugs.
Since I intend on releasing a new patch version in the next few days, let me know if you wish to pull-request a hotfix for it today or tomorrow.

@huri000 huri000 added the bug Something isn't working label Oct 27, 2018
@jgoodrick
Copy link
Contributor Author

Yeah, I'll give it a go. Thanks!

@huri000
Copy link
Owner

huri000 commented Oct 27, 2018

Thanks, and congrats on your first contribution! :-)
Released just now (0.8.4).

@huri000 huri000 closed this as completed Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants