Fix a large bunch of warnings #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
previously approved these changes
Jun 26, 2024
wxmerkt
commented
Jun 26, 2024
| template <int _SupportOptions> | ||
| inline void getShapeSupport(const Box* box, const Vec3f& dir, Vec3f& support, | ||
| int& /*unused*/, ShapeSupportData& /*unused*/) { | ||
| // ============================================================================ |
There was a problem hiding this comment.
Hmm, given the changes pre-commit is doing here this change may actually be unfavourable. I didn't see this :-( Would it be worth turning off Wpedantic then?
There was a problem hiding this comment.
we can surround those with // clang-format off and on
There was a problem hiding this comment.
Thanks for the reminder - I did that but it didn't work unless I did something wrong?
There was a problem hiding this comment.
This seems to work:
// clang-format off
template <int _SupportOptions>
inline void getShapeSupport(const Box* box, const Vec3f& dir, Vec3f& support,
int& /*unused*/, ShapeSupportData& /*unused*/) {
// clang-format onAnother solution is to cheat by removing the last semicolon inside the macro, so that we can add a semicolon at the end of the macro call, I guess.
wxmerkt
force-pushed
the
topic/wxm-fix-bunch-of-warnings
branch
from
c0fb226 to
76fab91
Compare
for more information, see https://pre-commit.ci
|
@lmontaut How do you want to proceed? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Won't get us to zero but will reduce some of the recent additions