Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep socket open throughout request #50

Open
rmccue opened this issue Jan 30, 2020 · 2 comments
Open

Keep socket open throughout request #50

rmccue opened this issue Jan 30, 2020 · 2 comments

Comments

@rmccue
Copy link
Member

rmccue commented Jan 30, 2020

In send_trace_to_daemon we're constantly opening and closing socket connections to the X-Ray daemon. We would likely be able to gain a bunch of performance by instead opening a connection at the start of the request, and only closing it again at the end of the request.

@rmccue
Copy link
Member Author

rmccue commented Feb 3, 2020

@joehoyle can you think of any reason not to do this?

@joehoyle
Copy link
Member

joehoyle commented Feb 3, 2020

Mm yeah I don't think there was any reason for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants