Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db sequel command does not work on Mac #191

Closed
Nikschavan opened this issue Jul 24, 2020 · 3 comments · Fixed by #192
Closed

db sequel command does not work on Mac #191

Nikschavan opened this issue Jul 24, 2020 · 3 comments · Fixed by #192
Labels
bug Existing functionality isn't behaving as expected

Comments

@Nikschavan
Copy link

Describe the bug
The error I get is - This command is only supported on MacOS, use composer server db info to see the database connection details.

php_uname( 's' ) returns Darwin for me, I am not sure if that is supposed to be different on Mac.

if ( php_uname( 's' ) === 'Darwin' ) {
$output->writeln( '<error>This command is only supported on MacOS, use composer server db info to see the database connection details.</error>' );
return 1;
}

Expected behavior
Command to work on Mac, If I comment this if condition, the database is loaded in sequel pro.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Mac OS 10.15.5

Additional context
Add any other context about the problem here.

@Nikschavan Nikschavan added the bug Existing functionality isn't behaving as expected label Jul 24, 2020
@Nikschavan Nikschavan changed the title 🐛 db sequel command does not work on Mac db sequel command does not work on Mac Jul 24, 2020
@roborourke
Copy link
Contributor

Ah this is a regression, the logic was reversed. I'll fix it asap.

@Nikschavan
Copy link
Author

Thanks for the quick fix! much appreciated ❤️

@roborourke
Copy link
Contributor

Released in 4.0.2 👍 - thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing functionality isn't behaving as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants