Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update humanmade/wp-redis with new caching functions #663

Open
4 tasks
kovshenin opened this issue Aug 8, 2022 · 3 comments
Open
4 tasks

Update humanmade/wp-redis with new caching functions #663

kovshenin opened this issue Aug 8, 2022 · 3 comments
Labels
should have Should be done, medium priority for now

Comments

@kovshenin
Copy link
Contributor

kovshenin commented Aug 8, 2022

Some new cache functions were introduced in WordPress 6.0:

The wp_cache_flush_runtime() in particular is quite interesting since it may be adopted by third-party plugins and libraries and expect to free up some memory, though the fallback/compat implementation does not free anything, so could result in exhausted memory errors. Since we have no way to determine whether runtime flushing is available, the work around that right now is to explicitly wp_suspend_cache_addition() for long-running (or high memory consumption) tasks, which is not ideal.

A wp_cache_flush_group() stub has also been introduced in 6.1, which should also be implemented.

The two upstream projects https://github.com/pantheon-systems/wp-redis and https://github.com/alleyinteractive/wp-redis haven't seen much activity lately, although there is a ticket open for some of these cache improvements.

Acceptance criteria

  • The wp_cache_*_multiple() functions are implemented in our object cache fork
  • The wp_cache_flush_group() function is implemented
  • The wp_cache_supports() function is implemented (WordPress 6.1: https://core.trac.wordpress.org/changeset/54448)
  • Tests for new functions are added, all tests are passing
@kovshenin kovshenin added should have Should be done, medium priority for now to refine Issues needing refine labels Aug 8, 2022
@CStukey
Copy link

CStukey commented Aug 10, 2022

@CStukey
Copy link

CStukey commented Aug 10, 2022

@jerico This ticket was refined and estimated during the Aug 10 refinement meeting.

@CStukey CStukey removed the to refine Issues needing refine label Aug 10, 2022
@spacedmonkey
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
should have Should be done, medium priority for now
Projects
None yet
Development

No branches or pull requests

3 participants