Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always print top chunk when run heap chunks -a #1170

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

xpoy1
Copy link

@xpoy1 xpoy1 commented Feb 4, 2025

Description

Test case: https://github.com/shellphish/how2heap/blob/master/glibc_2.39/house_of_tangerine.c

Top chunk cannot be printed after it's size changed, pero top chunk always access by arena.top, it should always been printed ever with a malform size.

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Copy link

github-actions bot commented Feb 4, 2025

🤖 Coverage update for 8826ced 🟢

Old New
Commit 7638efe 8826ced
Score 71.1152% 71.1152% (0)

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor changes, then it's good

Copy link

🤖 Coverage update for fea6e5d 🟢

Old New
Commit 57181d2 fea6e5d
Score 71.0907% 71.0907% (0)

@xpoy1
Copy link
Author

xpoy1 commented Feb 16, 2025

Sure, can check it again!
fea6e5d

print should use f-strings
Copy link

🤖 Coverage update for e4a9aa4 🟢

Old New
Commit 57181d2 e4a9aa4
Score 71.0907% 71.0907% (0)

hugsy
hugsy previously approved these changes Feb 17, 2025
Grazfather
Grazfather previously approved these changes Feb 17, 2025
@hugsy hugsy dismissed stale reviews from Grazfather and themself via 3c89d15 February 23, 2025 06:09
Copy link

🤖 Coverage update for 3c89d15 🟢

Old New
Commit 57181d2 3c89d15
Score 71.0907% 71.0907% (0)

@hugsy hugsy requested a review from Grazfather February 23, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants