Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing quotes in modeling_llava_next_video.py #33214

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add missing quotes in modeling_llava_next_video.py #33214

merged 1 commit into from
Aug 30, 2024

Conversation

juliendenize
Copy link
Contributor

What does this PR do?

This PR add a missing quote in the documentation of LLavaNextVideo model.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts
@stevhliu

LysandreJik
LysandreJik approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LysandreJik LysandreJik merged commit e259d6d into huggingface:main Aug 30, 2024
7 checks passed
@juliendenize juliendenize deleted the juliendenize-patch-llava_next_video-docs-quotes branch August 30, 2024 13:45
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
@juliendenize @zucchini-nlp
Add missing quotes in modeling_llava_next_video.py (huggingface#33214)
5a9c134
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
@juliendenize @itazap
Add missing quotes in modeling_llava_next_video.py (huggingface#33214)
1900d40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliendenize @LysandreJik