-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added doctring to SchedulerType class #32898
added doctring to SchedulerType class #32898
Conversation
@stevhliu i ran |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm not sure why the check_repo_consistency
test is failing since you didn't touch any of those files. cc @amyeroberts, do you know how we can fix this? I noticed the same error message in a separate PR here.
Co-authored-by: Steven Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@stevhliu @Arunprakash-A For the check_repo_consistency tests - the tests were failing because of packages on the test image. These should have been resolved now. Pushing an empty commit to trigger a new CI run should resolve. For |
I ran
|
@Arunprakash-A You have to commit and push the changes made when running |
Thanks @amyeroberts. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for improving the docstring here!
* added doctring to SchedulerType class * Remove trailing whitespace src/transformers/trainer_utils.py Co-authored-by: Steven Liu <[email protected]> * fixup --------- Co-authored-by: Steven Liu <[email protected]>
* added doctring to SchedulerType class * Remove trailing whitespace src/transformers/trainer_utils.py Co-authored-by: Steven Liu <[email protected]> * fixup --------- Co-authored-by: Steven Liu <[email protected]>
* added doctring to SchedulerType class * Remove trailing whitespace src/transformers/trainer_utils.py Co-authored-by: Steven Liu <[email protected]> * fixup --------- Co-authored-by: Steven Liu <[email protected]>
What does this PR do?
It adds the docstring for the class
SchedulerType
. Currently, the AutoDoc only displays the__call__
signature ofenum.EnumType
base class which is not helpful. One needs to look for the names and the respective mapping in the source code of trainer.py. Therefore, added the docstring that lists out all the available names and the scheduler types they are mapped to.Before submitting
Pull Request section?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Documentation: @stevhliu