Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickfix documentation #32566

Merged
merged 2 commits into from
Aug 26, 2024
Merged

quickfix documentation #32566

merged 2 commits into from
Aug 26, 2024

Conversation

molbap
Copy link
Contributor

@molbap molbap commented Aug 9, 2024

What does this PR do?

Nit on documentation, wrong Mamba class is used.

Fixes #32561
cc @ArthurZucker

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@SamPruden
Copy link

SamPruden commented Aug 9, 2024

I think this should probably also switch to Mamba2Config? It's not actually used in that example, so maybe it should be removed instead, but it's probably bad to have the wrong one there.

@molbap
Copy link
Contributor Author

molbap commented Aug 9, 2024

Right on @SamPruden !

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurZucker ArthurZucker merged commit 26f043b into main Aug 26, 2024
9 checks passed
@ArthurZucker ArthurZucker deleted the fix_mamba_docs branch August 26, 2024 15:49
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
* fix documentation

* update config
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Aug 30, 2024
* fix documentation

* update config
itazap pushed a commit to NielsRogge/transformers that referenced this pull request Sep 20, 2024
* fix documentation

* update config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mamba2 Codestral generation example fails to load mismatching state dict
4 participants