Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to Transformers example Pytorch link broken . Impact on navigation as well #25444

Closed
SoyGema opened this issue Aug 10, 2023 · 1 comment · Fixed by #25461
Closed

Access to Transformers example Pytorch link broken . Impact on navigation as well #25444

SoyGema opened this issue Aug 10, 2023 · 1 comment · Fixed by #25461

Comments

@SoyGema
Copy link
Contributor

SoyGema commented Aug 10, 2023

Hello there! 👋

Context

Exploring Pytorch translation example

Issue

There seems to be a broken link in Pytorch example in the Translation example, similar to what happened in #24497

# https://huggingface.co/docs/datasets/loading_datasets.html.

When I follow the link , the following message appears. And when I click the here link

Captura de pantalla 2023-08-10 a las 18 19 10

It redirects me to https://huggingface.co/docs/transformers/main/en/examples with an 404 error.

Potential fix

  1. Is that ok if I submit a quick fix as in Fix loading dataset docs link in run_translation.py example #24594 ?
  2. Would it be hard to try to submit a contrib of something like this? ...

specify doc redirects using a redirects.yml like in datasets and other libraries: https://github.com/huggingface/datasets/blob/main/docs/source/_redirects.yml

Do you know if this entails more than create than source folder and .yaml file? Would I have to study this?

@sgugger
Keep up the good work!

@sgugger
Copy link
Collaborator

sgugger commented Aug 11, 2023

For the redirects, you will have to see with the datasets team on their repo :-)
As for Transformers, happy to look at a PR fixing the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants