Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture improvements #65

Merged
merged 39 commits into from
Jul 31, 2024

Conversation

ylacombe
Copy link
Collaborator

@ylacombe ylacombe commented Jun 7, 2024

Supersedes #50 and #55:

sanchit-gandhi and others added 30 commits May 17, 2024 14:26
@Artyom17
Copy link

Artyom17 commented Jul 4, 2024

Any ETA on this to be completed (at least partially) and committed?

@sanchit-gandhi
Copy link
Collaborator

Should we merge this one when ready @ylacombe to make development of new features more straightforward? After merging this PR, we can open follow-ups to iterate on the design further. Should help with the integration of static cache (#89) among others! cc @eustlb

@sanchit-gandhi sanchit-gandhi mentioned this pull request Jul 24, 2024
@ylacombe
Copy link
Collaborator Author

ylacombe commented Jul 26, 2024

Let's merge it ASAP, would you like to make a quick review first? It's been quite thoroughly "tested" since I've trained new checkpoints with the current architecture and the new one, as well as testing generation when evaluating the model

Feel free to merge when you read the message if you don't make the review!

@ylacombe ylacombe changed the title [WIP] Architecture improvements Architecture improvements Jul 26, 2024
@sang-nguyen-ts
Copy link
Contributor

@ylacombe is there any update on this?

@ylacombe ylacombe merged commit 11b209e into huggingface:main Jul 31, 2024
@ylacombe
Copy link
Collaborator Author

@sang-nguyen-ts it's just been merged !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants