Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Llama 2 BetterTransformer Broken #1446

Closed
4 tasks
AjayP13 opened this issue Oct 13, 2023 · 5 comments
Closed
4 tasks

Llama 2 BetterTransformer Broken #1446

AjayP13 opened this issue Oct 13, 2023 · 5 comments
Labels
bettertransformer bug Something isn't working

Comments

@AjayP13
Copy link

AjayP13 commented Oct 13, 2023

System Info

On transformers==4.34.0, patching meta-llama/Llama-2-7b-chat-hf with BetterTransformer and then running results in the error:

Error: TypeError: llama_forward() got an unexpected keyword argument 'padding_mask'

Who can help?

@younesbelkada

Information

  • The official example scripts
  • My own modified scripts

Tasks

  • An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
  • My own task or dataset (give details below)

Reproduction (minimal, reproducible, runnable)

N/A

Expected behavior

N/A

@AjayP13 AjayP13 added the bug Something isn't working label Oct 13, 2023
@younesbelkada
Copy link
Contributor

Thanks for reporting, this should be already fixed on the main branch of transformers, can you try to install optimum from source?
We are also migrating BetterTransformer to transformers core. Check out this PR: huggingface/transformers#26572 for more details

@fxmarty
Copy link
Contributor

fxmarty commented Oct 16, 2023

Hi @AjayP13, thank you. Transformers added an argument padding_mask that broke BetterTransformer. The bug is fixed on the main branch, but we still did not do a pypi release.

@hengqujushi
Copy link

Same here, looking forward to this fix PR being merged into the main branch soon.

@fxmarty
Copy link
Contributor

fxmarty commented Oct 18, 2023

The fix PR is already in main!

@fxmarty fxmarty closed this as completed Oct 18, 2023
@fxmarty
Copy link
Contributor

fxmarty commented Oct 18, 2023

#1421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bettertransformer bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants