Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote_decode to remote_utils #10898

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

hlky
Copy link
Collaborator

@hlky hlky commented Feb 25, 2025

What does this PR do?

https://huggingface.co/blog/remote_vae

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hlky hlky requested a review from sayakpaul February 25, 2025 06:44
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Left some comments.

@hlky
Copy link
Collaborator Author

hlky commented Feb 25, 2025

Interface is unchanged for integrations of existing remote_decode method, main changes are docstrings and introducing return_type to support some other use cases.

@sayakpaul
Copy link
Member

@hlky WDYT about these changes https://github.com/sayakpaul/diffusers/pull/1/files?

@hlky
Copy link
Collaborator Author

hlky commented Feb 25, 2025

@sayakpaul LGTM, feel free to push to the branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants