-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlowMatch schedulers - closing the gap #9607
Comments
cc @hlky here too if interested! |
I'd have to dig into FlowMatch a bit more in the community implementations, but it looks like there's little difference between |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
ping to remove stale. |
any chance we get this one moving - given the popularity of flux and sd35 its one of the most frequent asks |
@sayakpaul @yiyixuxu @asomoza as requested yesterday in a discussion, tagging this as a high-priority ask. |
This is definitely high-prio and is something @yiyixuxu is actively considering/looking into. |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
As stated here, lets close the scheduler gap!
Problem statement:
FlowMatchEulerDiscreteScheduler
which creates a massive gap!(just for completeness, there is also an older implementation of
FlowMatchHeunDiscreteScheduler
, but its not updated to support requiredset_timesteps
ormu
inputs, so it cannot be used with newer DiT models like Flux.1)on the other hand, ComfyUI allows use of any regular scheduler with DiT and does not require separate duplicate -FlowMatch variant of the same scheduler (e.g. EulerDiscrete vs FlowMatchEulerDiscrete) with Flux.1.
reference: matrix of different schedulers used with Flux.1.Dev via ComfyUI:
https://civitai.com/articles/6582/flux1-dev-sampler-scheduler-comparison
cc: @yiyixuxu @sayakpaul @DN6 @asomoza
The text was updated successfully, but these errors were encountered: