Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FlaxLMSDiscreteScheduler jittable #2180

Open
pcuenca opened this issue Jan 31, 2023 · 8 comments
Open

Make FlaxLMSDiscreteScheduler jittable #2180

pcuenca opened this issue Jan 31, 2023 · 8 comments
Labels
good first issue Good for newcomers

Comments

@pcuenca
Copy link
Member

pcuenca commented Jan 31, 2023

Please, see discussion in #2155. I was under the wrong assumption that FlaxLMSDiscreteScheduler had been made jittable as part of #1661, but it never was.

@patrickvonplaten
Copy link
Contributor

Thanks for opening an issue here!

@patrickvonplaten patrickvonplaten added the good first issue Good for newcomers label Feb 3, 2023
@akshatvishu
Copy link

Hey! @patrickvonplaten , I will be willing to work on this as my issue but can you provide a rough summary of how to proceed or what the potential workflow looks like?

@dgarnitz
Copy link

dgarnitz commented May 7, 2023

@akshatvishu did this get fixed yet? If not, I am happy to jump into it.

@patrickvonplaten @pcuenca can this be fixed by adding @jax.jit to methods in FlaxLMSDiscreteScheduler? I imagine this can be tested by timing the jit & non-jit execution times to demonstrate jit is working - is that correct?

@Dan8991
Copy link

Dan8991 commented Jun 20, 2023

Since I don't see any open pull requests addressing this issue I guess that no-one is working on it anymore, can I give it a try?

@pcuenca
Copy link
Member Author

pcuenca commented Jun 20, 2023

@Dan8991 Absolutely!

@AbhinavJangra29
Copy link

is anyone working on it or is it fixed? if not can i start working on it?

@yiyixuxu
Copy link
Collaborator

@AbhinavJangra29 sure:)

@Dan8991
Copy link

Dan8991 commented Apr 17, 2024

Technically I still have the branch with the fix already implemented. It was never merged because the pull request remained opened for months without anyone reviewing it. If someone is willing to review it I can open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants