Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support latest Docker image in CI benchmarks #5433

Closed
albertvillanova opened this issue Jan 17, 2023 · 3 comments · Fixed by #5436
Closed

Support latest Docker image in CI benchmarks #5433

albertvillanova opened this issue Jan 17, 2023 · 3 comments · Fixed by #5436
Labels
enhancement New feature or request

Comments

@albertvillanova
Copy link
Member

Once we find out the root cause of:

we should revert the temporary pin on the Docker image version introduced by:
@albertvillanova albertvillanova added the enhancement New feature or request label Jan 17, 2023
@0x2b3bfa0
Copy link
Contributor

0x2b3bfa0 commented Jan 17, 2023 •
edited
Loading

Sorry, it was us:1 iterative/cml#1317 & iterative/cml#1319 (comment); should be fixed with v0.18.17.

Footnotes

  1. More or less, see https://github.com/yargs/yargs/issues/873. ↩

@0x2b3bfa0 0x2b3bfa0 mentioned this issue Jan 17, 2023
Merged
@0x2b3bfa0
Copy link
Contributor

Opened #5436 unpinning again the container image.

@albertvillanova
Copy link
Member Author

albertvillanova commented Jan 18, 2023 •
edited
Loading

Hi @0x2b3bfa0, thanks a lot for the investigation, the context about the the root cause and for fixing it!!

We are reviewing your PR to unpin the container image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert container image pin in CI benchmarks 0x2b3bfa0/datasets
2 participants
@albertvillanova @0x2b3bfa0