Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate to Japanese #114

Open
21 of 69 tasks
hiromu166 opened this issue Apr 12, 2022 · 41 comments
Open
21 of 69 tasks

Translate to Japanese #114

hiromu166 opened this issue Apr 12, 2022 · 41 comments

Comments

@hiromu166
Copy link
Contributor

hiromu166 commented Apr 12, 2022

Hi there 👋

Let's translate the course to YOUR-LANG so that the whole community can benefit from this resource 🌎!

Below are the chapters and files that need translating - let us know here if you'd like to translate any and we'll add your name to the list. Once you're finished, open a pull request and tag this issue by including #issue-number in the description, where issue-number is the number of this issue.

🙋 If you'd like others to help you with the translation, you can also post in our forums or tag @_lewtun on Twitter to gain some visibility.

We've also created a japanese-translations channel on the Hugging Face Discord in case you wish to discuss translation details there. Just follow the instructions here 👉 https://discord.gg/hKnxnxUr

Chapters

0 - Setup

1 - Transformer models

2 - Using 🤗 Transformers

3 - Fine-tuning a pretrained model

4 - Sharing models and tokenizers

5 - The 🤗 Datasets library

6 - The 🤗 Tokenizers library

7 - Main NLP tasks

8 - How to ask for help

Events

@shotaro-funai
Copy link

I'd like to translate a part of Chapter 3 - Fine-tuning a pretrained model (3.1, 3.2, and 3.3).
Can I ask you to add my name to the list?

@hiromu166
Copy link
Contributor Author

Hi @shotaro-funai.
Of course! I added your name to the list.
Thank you for your cooperation.

@yurikimura
Copy link

Hello @hiromu166 @shotaro-funai,
I'd like to ask you if I could work on chapter 2.
Also I need to apologize that I did chapter 1/2 by mistake, maybe I should decline and close the PR, but I appreciate if I could have any suggestion about it.
#169

@hiromu166
Copy link
Contributor Author

Hi @yurikimura.

I'd like to ask you if I could work on chapter 2.

Sure! Thank you for your cooperation.

Also I need to apologize that I did chapter 1/2 by mistake, maybe I should decline and close the PR, but I appreciate if I could have any suggestion about it.

Oh, I see. Unfortunately, I've already translated chapter 1/2 in my local, so could you close #169? I'm sorry to trouble you...

@yurikimura
Copy link

Hello @hiromu166 ,
I appreciate letting me do the 2nd part!
I have closed #169 now. Thank you for taking care of it!

@fxmarty
Copy link
Contributor

fxmarty commented May 10, 2022

@younesbelkada

@younesbelkada
Copy link
Contributor

younesbelkada commented May 10, 2022

@hiromu166 @yurikimura
Hey there! I am more than interested on your project - since I am familiar with japanese I guess I can help and see if I can validate your translations, I have few questions

@yurikimura
Copy link

Hello @younesbelkada, I am very sorry for late response.
I'm new here and I couldn't sure if I'd give you 100% correct answer, but as far as I know is following;

@younesbelkada
Copy link
Contributor

younesbelkada commented Jun 3, 2022

Hi @yurikimura
Thank you for your message!
Ok we can continue the discussion on this thread. Is there a plan to continue the translation? Also could you share with me your Twitter account? We want to Tweet this thread to the community to try to bring more contributors
よろしくお願いします!

@kojimano
Copy link

kojimano commented Jun 4, 2022

Hi @yurikimura, I heard of this project from @younesbelkada, and I'm also more than happy to contribute!
I'm a native Japanese speaker, doing a Ph.D. in the U.S. (also currently interning at HF). Pretty sure I can be useful here :)

@hiromu166
Copy link
Contributor Author

Sorry, I haven't checked this thread lately.

@younesbelkada
Thank you for your offer of cooperation! That's great for us.
As @yurikimura answered, we can continue the discussion here and our final PR is #144 .

Is there a plan to continue the translation? Also could you share with me your Twitter account? We want to Tweet this thread to the community to try to bring more contributors

Yes. My Twitter account is https://twitter.com/hiromoon166. That's a good idea to share this thread :)

@yurikimura
Thank you for answering the questions!

@hiromu166
Copy link
Contributor Author

@kojimano
I appreciate your cooperation!

I'm a native Japanese speaker, doing a Ph.D. in the U.S. (also currently interning at HF). Pretty sure I can be useful here :)

Wow! That's awesome! If you would like to translate some parts, please let me know.

@younesbelkada
Copy link
Contributor

Perfect here is the thread!
https://twitter.com/ybelkada/status/1532990394279116800?s=21&t=BpfDGoBzyc6coX7g0j3mFg

@HiromuHota
Copy link
Contributor

Hi all, I'm happy to take "4 - Sharing models and tokenizers"!

@TS-Soda
Copy link

TS-Soda commented Jun 4, 2022

Hi @hiromu166 ,
I found this project on Twitter.
I'd like to translate all the rest of Chapter 3. Can I ask you to add my name to the list?
I'm a native Japanese speaker, majoring in computer science at university in the U.S., so I'm a good fit for this project!

@younesbelkada
Copy link
Contributor

younesbelkada commented Jun 4, 2022

Thank you all for your contributions ! Can't wait to read the Japanese translations 🔥

@kojimano
Copy link

kojimano commented Jun 5, 2022

Let me do Chapter 5? @hiromu166, do you mind updating the list above? Thanks!
So excited to see this collaborative effort 🤗

@hiromu166
Copy link
Contributor Author

@HiromuHota @SodaTetsuhiro @kojimano

Thank you all :)
I've updated the list. Please check it.

@kuriyan1204
Copy link

kuriyan1204 commented Jun 5, 2022

Hi @hiromu166 , can I do the chapter6? Appreciate if you could add me on the list🤗

@webbigdata-jp
Copy link
Contributor

Hi. @hiromu166.
I saw this project on Twitter.
Can I do the chapter7 Main NLP tasks?

@younesbelkada
Copy link
Contributor

Hi @hiromu166 !
I am happy to do chapter8! Could you please add me on the list?
Very happy and excited to see all this efforts!

@younesbelkada
Copy link
Contributor

Also feel free to share your PRs once you have created it :) do not hesistate to request for our reviews as well for peer reviewing

@trtd56
Copy link
Contributor

trtd56 commented Jun 5, 2022

Hi @hiromu166 ! 🤗
I saw this project on Twitter but I guess I'm late...
Can I do the last "Events"?

@hiromu166
Copy link
Contributor Author

@kuriyan1204 @webbigdata-jp @younesbelkada @trtd56

Thank you all :)
I've updated the list. Please check it.

@HiromuHota
Copy link
Contributor

HiromuHota commented Jun 11, 2022

I'm wondering if anyone wants to discuss things more casually and in real-time.
There is #japanese-translations channel in HF's discord, hope to see you guys there!

We've also created a japanese-translations channel on the Hugging Face Discord in case you wish to discuss translation details there. Just follow the instructions here 👉 https://discord.gg/hKnxnxUr

@younesbelkada
Copy link
Contributor

Would love to join the discord! But it seems that I can't. Probably the link has expired .. could you send another link please?

@HiromuHota
Copy link
Contributor

@younesbelkada Thanks for your interest! I believe you can use this http://hf.co/join/discord (or see https://discuss.huggingface.co/t/join-the-hugging-face-discord/11263).

@HiromuHota
Copy link
Contributor

@younesbelkada and those who are interested, once you've joined HF's discord, react to this message in #course-translations with a :hugging_earth: emoji to show hidden channels like #japanese-translations.
image

@younesbelkada
Copy link
Contributor

Perfect just managed to join the channel!

@webbigdata-jp
Copy link
Contributor

hi.
I have stamped the discord channel.

By the way, I submitted a pull request and it failed with the following error.
files need to be formatted, run make style
https://github.com/huggingface/course/runs/6847421797?check_suite_focus=true

It seems to be an error that the file name is wrong, however, make style is not a problem in my local environment.
Does anyone know the cause of this?

@HiromuHota
Copy link
Contributor

@webbigdata-jp According to the GitHub Action, what failed was make quality. Do the followings:

  1. Run pip install -r requirements.txt
  2. Run make style
  3. Commit changed files and push

@webbigdata-jp
Copy link
Contributor

(hf_course) dev2@pop-os:~/git/course$ pip install -r requirements.txt Requirement already satisfied: nbformat>=5.1.3 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from -r requirements.txt (line 1)) (5.4.0) Requirement already satisfied: PyYAML>=5.4.1 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from -r requirements.txt (line 2)) (6.0) Requirement already satisfied: black in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from -r requirements.txt (line 3)) (19.10b0) Requirement already satisfied: jupyter-core in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from nbformat>=5.1.3->-r requirements.txt (line 1)) (4.10.0) Requirement already satisfied: fastjsonschema in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from nbformat>=5.1.3->-r requirements.txt (line 1)) (2.15.3) Requirement already satisfied: traitlets>=5.1 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from nbformat>=5.1.3->-r requirements.txt (line 1)) (5.2.2.post1) Requirement already satisfied: jsonschema>=2.6 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from nbformat>=5.1.3->-r requirements.txt (line 1)) (4.6.0) Requirement already satisfied: toml>=0.9.4 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (0.10.2) Requirement already satisfied: pathspec<1,>=0.6 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (0.7.0) Requirement already satisfied: regex in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (2022.3.15) Requirement already satisfied: attrs>=18.1.0 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (21.4.0) Requirement already satisfied: appdirs in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (1.4.4) Requirement already satisfied: click>=6.5 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (8.0.4) Requirement already satisfied: typed-ast>=1.4.0 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from black->-r requirements.txt (line 3)) (1.5.4) Requirement already satisfied: pyrsistent!=0.17.0,!=0.17.1,!=0.17.2,>=0.14.0 in /home/dev2/anaconda3/envs/hf_course/lib/python3.10/site-packages (from jsonschema>=2.6->nbformat>=5.1.3->-r requirements.txt (line 1)) (0.18.1) (hf_course) dev2@pop-os:~/git/course$ make style python utils/code_formatter.py (hf_course) dev2@pop-os:~/git/course$
I think it may be because the version of python is different.

@younesbelkada
Copy link
Contributor

Here is my draft PR: #249 in case anyone want already review it!
Please feel free to share your PR even if they are WIP ;)

@HiromuHota
Copy link
Contributor

@webbigdata-jp I believe you resolved the issue already, but black needed to be 22.3.0. This #252 will help prevent an issue like this going forward.

@webbigdata-jp
Copy link
Contributor

@HiromuHota @younesbelkada

Thanks for the advice.
I have re-created the python 3.10 environment in conda with python 3.6.
Now the test passes, but I didn't realize that black was the cause.

I haven't read through the discord yet, but I'll catch up later.

@younesbelkada
Copy link
Contributor

Hi @hiromu166 !
Could you please update the table below to have a broader view of the remaining chapters to translate 🙏 I think we have 3 chapters left if I am not mistaken
Thanks a lot !

@hiromu166
Copy link
Contributor Author

Could you please update the table below to have a broader view of the remaining chapters to translate 🙏

Sorry, I don't get what should I do... Could you tell me a little more detail?
(Do you mean to put a checkmark in the table above?)

@HiromuHota
Copy link
Contributor

@hiromu166 I believe @younesbelkada is referring to the table in the issue description (the very top of this page). Please check the item that's done.

@younesbelkada
Copy link
Contributor

@hiromu166 sorry I was unclear , yes I meant the table in the issue description since some chapter has been already translated ;)

@webbigdata-jp
Copy link
Contributor

Oh, my bad.
I thought hiromu166 and HiromuHota were the same person.
Sorry if I mentioned something wrong.

@hiromu166
Copy link
Contributor Author

I've updated the table! (chapter4 & event)
Thank you for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests