-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SFTConfig type wrong #178
Comments
The solution is simple. Go to src/configs and add these lines:
Don't forget to install the handbook with |
Thank you, @the-utkarshjain ! It took me a while to figure out TRL has switched and doesn't support the subclass of |
We also need to fix the DPOConfig that has the same problem. |
A quick fix is: |
This issue is in context with run_sft.py. Might occur with other tasks too.
The SFTTrainer class expects SFTConfig to be an instance of trl.SFTConfig. However, transformers.TrainingArguments is being passed. Due to this, the code usually throws an error when private variable of trl.SFTConfig like dataset_num_proc, etc are not passed. The bigger issue is that the code works with transformers.TrainingArguments, so you can't even pass those variables through the YAML file, or else the code throws an error saying there are extra arguments which aren't used by the program.
The text was updated successfully, but these errors were encountered: