Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch_sampler maybe None error #3025

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Conversation

candlewill
Copy link
Contributor

Fix batch_sampler maybe None error

Fixes # (issue)

#3011

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@BenjaminBossan
Copy link
Member

Thanks a lot for creating the PR. If you could also add a unit test to test_data_loader.py, that would be great. The test could basically be the same as the example you provided in the issue.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with Benjamin, let's add a test here then ✅ , thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Add unit test for dataloader with batch_size=None when using Iterabledataset
@candlewill
Copy link
Contributor Author

The unit test code is added, please help to review and merge.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall this looks good to me, please run pip install -e .[quality]; make style; make quality; to fix the quality failures, and I made a comment for why the tests are failing

tests/test_data_loader.py Outdated Show resolved Hide resolved
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test @candlewill. This PR is almost good to go, only the linter needs to be satisfied. This is because these lines are indented one level too far.

Fix inconsistent indentation
@candlewill
Copy link
Contributor Author

I am sure now everything is OK, please help review again.

Copy link
Collaborator

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test!

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@muellerzr muellerzr merged commit 2d4f1dd into huggingface:main Aug 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants