Fixup MS-AMP integration #3023
Closed
Fixup MS-AMP integration #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muellerzr
commented
Aug 16, 2024
Comment on lines
-309
to
+314
| if os.environ.get("ACCELERATE_USE_FSDP", "false") == "true" or isinstance( | ||
| fsdp_plugin, FullyShardedDataParallelPlugin | ||
| ): | ||
| if is_torch_version("<", FSDP_PYTORCH_VERSION): | ||
| raise ValueError(f"FSDP requires PyTorch >= {FSDP_PYTORCH_VERSION}") | ||
| # if os.environ.get("ACCELERATE_USE_FSDP", "false") == "true" or isinstance( | ||
| # fsdp_plugin, FullyShardedDataParallelPlugin | ||
| # ): | ||
| # if is_torch_version("<", FSDP_PYTORCH_VERSION): | ||
| # raise ValueError(f"FSDP requires PyTorch >= {FSDP_PYTORCH_VERSION}") |
There was a problem hiding this comment.
Here I need to adjust for the FSDP version, as it doesn't quite work on the .dev related additionals when using the docker image
There was a problem hiding this comment.
Relying on #3024 to fix
muellerzr
force-pushed
the
muellerzr-msamp-ds-fsdp
branch
from
1c78d9e
to
4a37e5f
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Okay, let's wait until the MS-AMP PR is merged and then revisit this PR. |
4 tasks
|
Will be closing this PR and opening another. Game plan is to keep all but the FSDP support but I'll keep this here for transparency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes up the MS-AMP integration to include:
Closes #2143
Closes #2971
Closes #2972
IMPORTANT:
pip install git+https://github.com/muellerzr/MS-AMP@muellerzr-make-optim-init-easierBefore submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@BenjaminBossan @SunMarc