From 4cc6eed0d7fe4227a6a4a1338eb7abe9e76e84bf Mon Sep 17 00:00:00 2001 From: Marc Sun Date: Wed, 15 May 2024 17:31:24 +0200 Subject: [PATCH 1/4] skip --- tests/test_big_modeling.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/test_big_modeling.py b/tests/test_big_modeling.py index 9533207149d..d66341ce919 100644 --- a/tests/test_big_modeling.py +++ b/tests/test_big_modeling.py @@ -484,7 +484,10 @@ def forward(self, x): del model gc.collect() + # This test fails because the data_ptr() of compute2.weight is sometime the same of compute1.weight. + # I check that the values are not the same but it gives the same address. This does not happen on my local machine. @require_cuda + @unittest.skip("Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test") def test_dispatch_model_tied_weights_memory_with_nested_offload_disk(self): # Test that we do not duplicate tied weights at any point during dispatch_model call. From 0762fa9ee883618e9d88dd31fee646afb187c870 Mon Sep 17 00:00:00 2001 From: Marc Sun Date: Wed, 15 May 2024 17:37:06 +0200 Subject: [PATCH 2/4] fix --- tests/test_big_modeling.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/test_big_modeling.py b/tests/test_big_modeling.py index d66341ce919..fc3d213e86c 100644 --- a/tests/test_big_modeling.py +++ b/tests/test_big_modeling.py @@ -484,7 +484,7 @@ def forward(self, x): del model gc.collect() - # This test fails because the data_ptr() of compute2.weight is sometime the same of compute1.weight. + # This test fails because sometimes data_ptr() of compute2.weight is the same of compute1.weight. # I check that the values are not the same but it gives the same address. This does not happen on my local machine. @require_cuda @unittest.skip("Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test") From 686419974dfdd4c6e4bb2c8a4029a1f55036aabe Mon Sep 17 00:00:00 2001 From: Marc Sun Date: Wed, 15 May 2024 17:38:35 +0200 Subject: [PATCH 3/4] quality --- tests/test_big_modeling.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_big_modeling.py b/tests/test_big_modeling.py index fc3d213e86c..4dd29ae575f 100644 --- a/tests/test_big_modeling.py +++ b/tests/test_big_modeling.py @@ -487,7 +487,9 @@ def forward(self, x): # This test fails because sometimes data_ptr() of compute2.weight is the same of compute1.weight. # I check that the values are not the same but it gives the same address. This does not happen on my local machine. @require_cuda - @unittest.skip("Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test") + @unittest.skip( + "Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test" + ) def test_dispatch_model_tied_weights_memory_with_nested_offload_disk(self): # Test that we do not duplicate tied weights at any point during dispatch_model call. From c55e84393e9aacdbd2fb8c343c9ec534d5c44ea1 Mon Sep 17 00:00:00 2001 From: Marc Sun Date: Thu, 16 May 2024 11:40:23 +0200 Subject: [PATCH 4/4] fix comment --- tests/test_big_modeling.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_big_modeling.py b/tests/test_big_modeling.py index 4dd29ae575f..8d6838423ee 100644 --- a/tests/test_big_modeling.py +++ b/tests/test_big_modeling.py @@ -484,8 +484,8 @@ def forward(self, x): del model gc.collect() - # This test fails because sometimes data_ptr() of compute2.weight is the same of compute1.weight. - # I check that the values are not the same but it gives the same address. This does not happen on my local machine. + # This test fails because sometimes data_ptr() of compute2.weight is the same as compute1.weight. + # I checked that the values are not the same but it gives the same address. This does not happen on my local machine. @require_cuda @unittest.skip( "Flaky test, we should have enough coverage with test_dispatch_model_tied_weights_memory_with_nested_offload_cpu test"