Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sharded cpu resume #2762

Merged
merged 1 commit into from
May 10, 2024
Merged

Enable sharded cpu resume #2762

merged 1 commit into from
May 10, 2024

Conversation

muellerzr
Copy link
Collaborator

@muellerzr muellerzr commented May 10, 2024

What does this PR do?

Enables sharded CPU resuming when using FSDP and CPU offloading is enabled

For people potentially googling:

This solves the issue where you could hit a CUDA out-of-memory (CUDA OOM) issue when resuming checkpoints as it would try to load everything onto the GPU, when instead we need to offload on CPU

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pacman100

@muellerzr
Copy link
Collaborator Author

muellerzr commented May 10, 2024

Note this won't work right now due to #2757

Edit: reverted and rebased

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@muellerzr muellerzr requested a review from pacman100 May 10, 2024 15:23
@muellerzr muellerzr merged commit 67308ca into main May 10, 2024
25 checks passed
@muellerzr muellerzr deleted the fsdp_offload branch May 10, 2024 15:39
muellerzr added a commit that referenced this pull request May 10, 2024
muellerzr added a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants